Skip to content

Fix bare except clauses in abstract_solver.py, constraints.py, and monitors.py #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koteshyelamati wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix bare except clauses in abstract_solver.py, constraints.py, and monitors.py #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
626c77b
Fix bare except in abstract_solver.py: use except (TypeError, ValueEr…
koteshyelamati Jul 12, 2026
6715719
Fix bare except in constraints.py: use except AttributeError
koteshyelamati Jul 12, 2026
a793e6e
Fix bare except in monitors.py: use except Exception
koteshyelamati Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mystic/abstract_solver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ def SetMultinormalInitialPoints(self, mean, var=None):
else:
try: # scalar ?
float(var)
except: # nope. var better be matrix of the right size (no check)
except (TypeError, ValueError): # nope. var better be matrix of the right size (no check)
pass
else:
var = var * numpy.eye(self.nDim)
Expand Down
2 changes: 1 addition & 1 deletion mystic/constraints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ def issolution(constraints, guess, tol=1e-3):
else: # is a constraints solver
try:
constrained = guess.copy()
except:
except AttributeError:
from copy import deepcopy
constrained = deepcopy(guess)
error = 0.0
Expand Down
2 changes: 1 addition & 1 deletion mystic/monitors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,7 +640,7 @@ def _load(path, monitor=None, verbose=False): #XXX: duplicate in mystic.munge?
params = _globals['___params'] if '___params' in _globals else None
cost = _globals['___cost'] if '___cost' in _globals else None
del _globals
except: #XXX: should only catch the appropriate exceptions
except Exception: #XXX: should only catch the appropriate exceptions
raise OSError("error reading '{path}'".format(path=path))

finally:
Expand Down