feat: add s3 retention config for etcd snapshots - #2402
Merged
Conversation
Co-authored-by: Matt Trachier <matt.trachier@suse.com> (cherry picked from commit 4845c29)
jiaqiluo
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request cherry-picks the changes from #2337 into release/v15
Addresses #2339 for #2338
WARNING!: to avoid having to resolve merge conflicts this PR is generated with 'git cherry-pick -X theirs'.
Please make sure to carefully inspect this PR so that you don't accidentally revert anything!
Copied from main PR:
Rancher now supports a separate retention count for S3-stored etcd snapshots, independent of the local snapshot_retention value.
Description
Testing
My current cluster is configured with the following etcd configuration in rancher2_cluster_v2.rke_config.etcd
Updating the provider doesn't make any changes to the existing cluster configuration.
Next updating the provider and setting retention = 3 results in the following changes
Not a breaking change.