[v2.14] Open the OAuth authorize URL on Windows without a shell - #664
Open
pmatseykanets wants to merge 1 commit into
Open
[v2.14] Open the OAuth authorize URL on Windows without a shell#664pmatseykanets wants to merge 1 commit into
pmatseykanets wants to merge 1 commit into
Conversation
On Windows, openBrowser launched the browser via `cmd /c start "" <url>`. cmd.exe parses `&` as a command separator, so authorize URLs with multiple query parameters (e.g. Azure AD's client_id, scope, response_type) were truncated before reaching the browser, causing AADSTS900144 failures. openBrowser now delegates OS-specific launching to a new osOpenURL function. The Windows implementation uses the ShellExecute API, passing the URL as an opaque argument with no command line built, so it can't be reinterpreted by a shell. macOS and Linux keep using exec.Command with the URL as a single argv element, unchanged in behavior. golang.org/x/sys moves from an indirect to a direct dependency, matching the new osOpenURL import.
pmatseykanets
requested review from
JonCrowther,
andreas-kupries and
bigkevmcd
September 1, 2026 19:44
andreas-kupries
approved these changes
Sep 2, 2026
bigkevmcd
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#56970
Backport of #657