fix(spec/compat): optional Sum in OTel histogram to NHCB handling - #5271
Draft
krajorama wants to merge 1 commit into
Draft
fix(spec/compat): optional Sum in OTel histogram to NHCB handling#5271krajorama wants to merge 1 commit into
krajorama wants to merge 1 commit into
Conversation
Revealed in open-telemetry#5125 (comment) The protobuf format and model has the Sum as optional, however Sum in native histograms is not optional. Drop the sample instead of making up a value. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Pull request dashboard statusWaiting on the author · refreshed 2026-08-20 15:49 UTC Move out of draft to request review. Status above doesn't look right?
|
krajorama
force-pushed
the
krajo/fix-opt-sum-to-nhcb
branch
from
August 17, 2026 07:50
94c769c to
887108b
Compare
krajorama
marked this pull request as draft
August 17, 2026 08:41
dashpole
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked on general discussion in #5273 first.
Revealed in
#5125 (comment)
Fixes N/A
Changes
Specify that when converting an OpenTelemetry Histogram to a Prometheus Native Histogram with Custom Buckets (NHCB); if the
Sumis not present, then drop the data point and do not convert it. TheSumis not optional innative histograms and we should not make up a value instead of it.
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check