Add Instrumentation Supplementary Guidelines - #5191
Conversation
c7585e8 to
2306300
Compare
|
I reviewed the content, and think it is correct and useful. My main question is still whether this is the right place for it to live. I see this kind of document as user-facing, so I had imagined that it would be integrated into opentelemetry.io in a more discoverable way. But i'm open to other opinions. |
The main audience is instrumentation library authors. We do have supplementary guidelines for sdk authors, sdk extension point authors etc. So not a bad idea to keep it in spec repo. (And have a link from the docs website https://opentelemetry.io/docs/concepts/instrumentation/libraries/ ) |
|
See my comment on the issue (#5148 (comment)): I am a big fan of having instrumentation guidelines, but we should decide if they sit in the spec, or if people would find them more easily in the docs. |
Would open-telemetry/opentelemetry.io#10815 be sufficient for the discoverability part? |
|
My preference is still to have the source of truth be the stand-alone, user-facing documentation on opentelemetry.io. The spec is the right place for content that is primarily for language implementation authors. This seems like content that is primarily for end users / instrumentation authors. I would expect the main, authoritative content to be on opentelemetry.io, and I would expect our supplementary guidelines to reference that, and add any details that are specific to instrumentation for sdks. |
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-27 19:15 UTC Review the latest changes. Status above doesn't look right?
|
This comment has been minimized.
This comment has been minimized.
The audience is library owners who instrument natively or instrumentation library authors, not just end users. Spec's existing supplementary guidelines already serve them. So, this PR is consistent with what the spec uses supplementary guidelines already for. I don't see any discoverability issue (open-telemetry/opentelemetry.io#10815 can help). |
|
We actually have a top level |
I only see existing supplementary guidelines for each signal directory (logs/metrics) separately. |
Signed-off-by: cijothomas <cijo.thomas@gmail.com>
…ementary-guidelines Signed-off-by: cijothomas <cijo.thomas@gmail.com> # Conflicts: # CHANGELOG.md
Fixes #5148
Companion PR for the website to ease discoverability: open-telemetry/opentelemetry.io#10815