Skip to content

Add Instrumentation Supplementary Guidelines - #5191

Open
cijothomas wants to merge 4 commits into
open-telemetry:mainfrom
cijothomas:instrumentation-supplementary-guidelines
Open

Add Instrumentation Supplementary Guidelines#5191
cijothomas wants to merge 4 commits into
open-telemetry:mainfrom
cijothomas:instrumentation-supplementary-guidelines

Conversation

@cijothomas

@cijothomas cijothomas commented Jul 4, 2026

Copy link
Copy Markdown
Member

Fixes #5148

Companion PR for the website to ease discoverability: open-telemetry/opentelemetry.io#10815

@cijothomas
cijothomas force-pushed the instrumentation-supplementary-guidelines branch from c7585e8 to 2306300 Compare July 4, 2026 05:18
@cijothomas
cijothomas marked this pull request as ready for review July 4, 2026 05:21
@cijothomas
cijothomas requested a review from a team as a code owner July 4, 2026 05:21
@dashpole

dashpole commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

I reviewed the content, and think it is correct and useful. My main question is still whether this is the right place for it to live. I see this kind of document as user-facing, so I had imagined that it would be integrated into opentelemetry.io in a more discoverable way. But i'm open to other opinions.

@cijothomas

Copy link
Copy Markdown
Member Author

I reviewed the content, and think it is correct and useful. My main question is still whether this is the right place for it to live. I see this kind of document as user-facing, so I had imagined that it would be integrated into opentelemetry.io in a more discoverable way. But i'm open to other opinions.

The main audience is instrumentation library authors. We do have supplementary guidelines for sdk authors, sdk extension point authors etc. So not a bad idea to keep it in spec repo. (And have a link from the docs website https://opentelemetry.io/docs/concepts/instrumentation/libraries/ )

Comment thread specification/instrumentation-supplementary-guidelines.md
@svrnm

svrnm commented Jul 13, 2026

Copy link
Copy Markdown
Member

See my comment on the issue (#5148 (comment)): I am a big fan of having instrumentation guidelines, but we should decide if they sit in the spec, or if people would find them more easily in the docs.

@cijothomas

Copy link
Copy Markdown
Member Author

See my comment on the issue (#5148 (comment)): I am a big fan of having instrumentation guidelines, but we should decide if they sit in the spec, or if people would find them more easily in the docs.

Would open-telemetry/opentelemetry.io#10815 be sufficient for the discoverability part?

@lmolkova lmolkova assigned lmolkova and jmacd and unassigned lmolkova Jul 22, 2026
@cijothomas

Copy link
Copy Markdown
Member Author

@svrnm @dashpole Could you re-review and share your thoughts on keeping it in spec repo (this PR) and modify website docs as suggested here ?

@dashpole

dashpole commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

My preference is still to have the source of truth be the stand-alone, user-facing documentation on opentelemetry.io. The spec is the right place for content that is primarily for language implementation authors. This seems like content that is primarily for end users / instrumentation authors. I would expect the main, authoritative content to be on opentelemetry.io, and I would expect our supplementary guidelines to reference that, and add any details that are specific to instrumentation for sdks.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pull request dashboard status

Waiting on reviewers · refreshed 2026-08-27 19:15 UTC

Review the latest changes.

Status above doesn't look right?
  • Just replied or pushed? Anything around or after the refresh time above may not be picked up yet — give it a few minutes.
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@opentelemetry-pr-dashboard

This comment has been minimized.

@cijothomas

Copy link
Copy Markdown
Member Author

My preference is still to have the source of truth be the stand-alone, user-facing documentation on opentelemetry.io. The spec is the right place for content that is primarily for language implementation authors. This seems like content that is primarily for end users / instrumentation authors. I would expect the main, authoritative content to be on opentelemetry.io, and I would expect our supplementary guidelines to reference that, and add any details that are specific to instrumentation for sdks.

The audience is library owners who instrument natively or instrumentation library authors, not just end users. Spec's existing supplementary guidelines already serve them.
Eg: Metric supplementary guidelines - it says it's targeting instrumentation library authors.. Any end user who is writing instrumentation would benefit from the content there.
Logs supplementary guidelines - processor patterns for extension authors.
neither is normative, and both live in spec repo.

So, this PR is consistent with what the spec uses supplementary guidelines already for. I don't see any discoverability issue (open-telemetry/opentelemetry.io#10815 can help).

@carlosalberto

Copy link
Copy Markdown
Contributor

We actually have a top level supplementary-guidelines directory. Maybe we should put this doc there?

Comment thread specification/instrumentation-supplementary-guidelines.md
@cijothomas

Copy link
Copy Markdown
Member Author

We actually have a top level supplementary-guidelines directory. Maybe we should put this doc there?

I only see existing supplementary guidelines for each signal directory (logs/metrics) separately.
Or did you meant https://github.com/open-telemetry/opentelemetry-specification/tree/main/supplementary-guidelines which seem to be something like a leftover, and is not under specification directory.

Signed-off-by: cijothomas <cijo.thomas@gmail.com>
…ementary-guidelines

Signed-off-by: cijothomas <cijo.thomas@gmail.com>

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider cross-language guidelines for instrumentation library authors

6 participants