Skip to content

ci: move security scanning to shared workflow - #3900

Merged
julianocosta89 merged 6 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/batch-9-20260825-20260826
Sep 1, 2026
Merged

ci: move security scanning to shared workflow#3900
julianocosta89 merged 6 commits into
open-telemetry:mainfrom
opentelemetrybot:zizmor-rollout/batch-9-20260825-20260826

Conversation

@opentelemetrybot

Copy link
Copy Markdown
Contributor

Tracked in open-telemetry/sig-security#293.

Moves existing zizmor scanning to the OpenTelemetry shared workflow.

The workflow:

  • runs the pedantic persona on pull requests, pushes to main;
  • uploads results to GitHub code scanning;
  • uses the shared workflow pinned to an immutable commit.

After merge

  1. Confirm the Zizmor workflow succeeds on the merged default-branch commit and its code-scanning analysis has no findings.
  2. Confirm open-telemetry/admin continues to require zizmor code scanning for this repository.
  3. On the next repository pull request, confirm GitHub reports a required zizmor code-scanning result.

If enforcement unexpectedly blocks a valid change, restore require_zizmor = false in open-telemetry/admin while leaving scanning enabled.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Moves the repository’s zizmor security scan from a locally-defined reusable workflow to the OpenTelemetry shared zizmor workflow, and runs it directly on PRs / main / schedule with SARIF upload to GitHub Code Scanning.

Changes:

  • Replaced the in-repo zizmor job steps with a call to open-telemetry/shared-workflows pinned to an immutable commit.
  • Changed zizmor execution from workflow_call (invoked by checks.yml) to direct workflow triggers (pull_request, push to main, schedule, workflow_dispatch).
  • Removed the zizmor job from checks.yml since it’s now a standalone workflow.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/zizmor.yml Switches zizmor scanning to the shared workflow and adds direct triggers + SARIF upload permissions.
.github/workflows/checks.yml Removes the zizmor job previously calling the local reusable workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/zizmor.yml
Comment thread .github/workflows/zizmor.yml
@julianocosta89

Copy link
Copy Markdown
Member

@trask 2 questions on this PR.

  1. Can I update it to ready for review and follow the "After merge" steps?
  2. Should we address the copilot findings?

@opentelemetrybot
opentelemetrybot force-pushed the zizmor-rollout/batch-9-20260825-20260826 branch from eea78aa to 289dc97 Compare August 27, 2026 17:18
@trask
trask requested a lite review from Copilot August 27, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread .github/workflows/checks.yml
Comment thread .github/workflows/zizmor.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@opentelemetrybot
opentelemetrybot marked this pull request as ready for review August 27, 2026 22:37
@opentelemetrybot
opentelemetrybot requested a review from a team as a code owner August 27, 2026 22:37
@trask

trask commented Aug 28, 2026

Copy link
Copy Markdown
Member

@trask 2 questions on this PR.

  1. Can I update it to ready for review and follow the "After merge" steps?
  2. Should we address the copilot findings?

sorry, the rollout got stalled, PR should be good to go now

Comment thread .github/workflows/checks.yml
@julianocosta89
julianocosta89 added this pull request to the merge queue Sep 1, 2026
Merged via the queue into open-telemetry:main with commit 779458c Sep 1, 2026
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants