ci: move security scanning to shared workflow - #3900
Conversation
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Moves the repository’s zizmor security scan from a locally-defined reusable workflow to the OpenTelemetry shared zizmor workflow, and runs it directly on PRs / main / schedule with SARIF upload to GitHub Code Scanning.
Changes:
- Replaced the in-repo zizmor job steps with a call to
open-telemetry/shared-workflowspinned to an immutable commit. - Changed zizmor execution from
workflow_call(invoked bychecks.yml) to direct workflow triggers (pull_request,pushtomain,schedule,workflow_dispatch). - Removed the zizmor job from
checks.ymlsince it’s now a standalone workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/zizmor.yml | Switches zizmor scanning to the shared workflow and adds direct triggers + SARIF upload permissions. |
| .github/workflows/checks.yml | Removes the zizmor job previously calling the local reusable workflow. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@trask 2 questions on this PR.
|
eea78aa to
289dc97
Compare
sorry, the rollout got stalled, PR should be good to go now |
Tracked in open-telemetry/sig-security#293.
Moves existing zizmor scanning to the OpenTelemetry shared workflow.
The workflow:
pedanticpersona on pull requests, pushes tomain;After merge
open-telemetry/admincontinues to require zizmor code scanning for this repository.zizmorcode-scanning result.If enforcement unexpectedly blocks a valid change, restore
require_zizmor = falseinopen-telemetry/adminwhile leaving scanning enabled.