node: fg: remove DisableCPUQuotaWithExclusiveCPUs

[ffromani]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The FG removal was planned for 1.38, so delete it

Which issue(s) this PR is related to:

Related to #127525

Special notes for your reviewer:

Do we need to obey to emulation support for kubelet-only FGs? see #141758 (comment)

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[kubernetes-prow]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ffromani]

/sig node

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign sergeykanzhelev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/features/OWNERS
• pkg/kubelet/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

turns out we need to wait more than anticipated?

$ ./hack/update-featuregates.sh 
found 234 features in FeatureSpecMap var defaultVersionedKubernetesFeatureGates in file: /home/fromani/go/src/k8s.io/kubernetes/pkg/features/kube_features.go
found 3 features in FeatureSpecMap var defaultVersionedKubernetesFeatureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/features/kube_features.go
found 38 features in FeatureSpecMap var defaultVersionedKubernetesFeatureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/apiserver/pkg/features/kube_features.go
found 3 features in FeatureSpecMap of func featureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/component-base/logs/api/v1/kube_features.go
found 1 features in FeatureSpecMap of func featureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/component-base/metrics/features/kube_features.go
found 2 features in FeatureSpecMap of func featureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/component-base/zpages/features/kube_features.go
found 3 features in FeatureSpecMap var versionedCloudPublicFeatureGates in file: /home/fromani/go/src/k8s.io/kubernetes/staging/src/k8s.io/controller-manager/pkg/features/kube_features.go
Failed to update versioned feature list: 
feature DisableCPUQuotaWithExclusiveCPUs cannot be removed until version 1.40 (required for emulation support)exit status 1

[natasha41575]

Yeah it needs to be removed in 1.40 (GA+3)

[natasha41575]

maybe just update the comment

[ffromani]

but does the kubelet support feature emulation? IIRC still not

[natasha41575]

Oh, it's a kubelet-only FG. Yeah you are right I don't think kubelet supports emulation

Should the script somehow detect when a FG is used only by kubelet and skip this check if so? Sounds a bit complicated

[ffromani]

/hold

see comments about emulated version

[kubernetes-prow]

@ffromani: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-verify	d01f1d9	link	true	/test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.