markdown: fix hyperlink rendering and detection - #1442
Open
simonklee wants to merge 3 commits into
Open
Conversation
Make named and bare links clickable without exposing their destinations when the terminal supports OSC 8. Preserve visible URL fallbacks elsewhere and keep links intact across formatting, streaming, wrapping, and late terminal capability detection. Fix #1439
Streaming Markdown updates could expose stale link labels or targets, while hover feedback mutated rendered text and repeatedly resolved URLs. Keep previews consistent and hover feedback responsive without altering rendered content.
Collaborator
|
Blocker: links lose OSC 8 metadata after preceding multibyte text because Tree-sitter byte offsets are treated as JS string offsets. Please add named + bare Unicode regression coverage. |
Member
Author
👍🏻 |
ASCII-only tests miss mismatches between string offsets and terminal cell positions. Check Unicode link targets after wide and combining characters to catch misplaced hyperlink metadata, with or without terminal hyperlink support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make named and bare links clickable without exposing their destinations
when the terminal supports OSC 8. Preserve visible URL fallbacks
elsewhere and keep links intact across formatting, streaming, wrapping,
and late terminal capability detection.
Fix #1439