Default the Node.js winget prompt to yes

User feedback: when the installer asks "Install Node.js LTS now via
winget (OpenJS.NodeJS.LTS, no admin)?" the default should be yes, not
no. The alternative when the user just hits enter today is "installer
aborts with no progress, user manually downloads Node from nodejs.org,
re-runs the installer" — strictly worse than letting us run a no-admin
winget install. Saying no is still one keystroke (`n`).

Adds an optional default-answer argument to Confirm-Rf (PowerShell) /
rf::confirm (bash) so callers can opt into the inverted "[Y/n]" prompt
with empty-input = yes. Only the Node prompt opts in. The existing
"Remove Roboflow from: ..." uninstall confirms keep the safe legacy
"[y/N]" default-no (no -DefaultAnswer flag passed).

Pester Prereq.Tests.ps1: 6/6 green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: yeldarby

installer/lib/common.ps1

@@ -45,8 +45,19 @@ function Invoke-RfDie {
 }
 
 function Confirm-Rf {
-    param([string]$Prompt)
+    param(
+        [string]$Prompt,
+        # 'y' means the prompt shows "[Y/n]" and enter without input is yes;
+        # 'n' (default) keeps the legacy "[y/N]" with no-on-enter.
+        [ValidateSet('y', 'n')]
+        [string]$DefaultAnswer = 'n'
+    )
     if ($Script:RfYes) { return $true }
+    if ($DefaultAnswer -eq 'y') {
+        $reply = Read-Host "$Prompt [Y/n]"
+        if ([string]::IsNullOrEmpty($reply)) { return $true }
+        return $reply -notmatch '^[Nn]'
+    }
     $reply = Read-Host "$Prompt [y/N]"
     return $reply -match '^[Yy]'
 }

installer/lib/common.sh

@@ -41,14 +41,22 @@ rf::die() {
     exit "${RF_EXIT_CODE:-1}"
 }
 
-# rf::confirm <prompt>  — returns 0 for yes, 1 for no. Auto-yes if RF_YES=1.
+# rf::confirm <prompt> [default]  — returns 0 for yes, 1 for no.
+# Auto-yes if RF_YES=1. Default arg "y" inverts the prompt to "[Y/n]" and
+# treats an empty answer as yes; default "n" (or omitted) is the legacy
+# "[y/N]" with no-on-enter.
 rf::confirm() {
     if [[ "${RF_YES:-0}" == "1" ]]; then
         return 0
     fi
-    local prompt="$1" reply
-    read -r -p "$prompt [y/N] " reply </dev/tty
-    [[ "$reply" =~ ^[Yy] ]]
+    local prompt="$1" default="${2:-n}" reply
+    if [[ "$default" == "y" ]]; then
+        read -r -p "$prompt [Y/n] " reply </dev/tty
+        [[ -z "$reply" || "$reply" =~ ^[Yy] ]]
+    else
+        read -r -p "$prompt [y/N] " reply </dev/tty
+        [[ "$reply" =~ ^[Yy] ]]
+    fi
 }
 
 # rf::prompt <prompt> [default]  — read a line from /dev/tty.

installer/lib/prereq.ps1

@@ -55,7 +55,11 @@ function Confirm-RfNpxAvailable {
     }
 
     if (-not $Script:RfYes) {
-        if (-not (Confirm-Rf -Prompt "Install Node.js LTS now via $(Get-RfNodeInstallMethodLabel)?")) {
+        # Default to yes: the alternative is "installer aborts with no
+        # progress, user manually installs Node, re-runs," which is worse
+        # than a winget install in every case where the user didn't have a
+        # specific reason to refuse. Refusing is still one keystroke (`n`).
+        if (-not (Confirm-Rf -Prompt "Install Node.js LTS now via $(Get-RfNodeInstallMethodLabel)?" -DefaultAnswer 'y')) {
             Write-RfErr 'Node.js is required to proceed. Install it from https://nodejs.org and re-run agents.ps1.'
             return $false
         }

installer/lib/prereq.sh

@@ -67,7 +67,11 @@ rf::prereq::ensure_npx() {
     fi
 
     if [[ "${RF_YES:-0}" != "1" ]]; then
-        if ! rf::confirm "Install Node.js LTS now via $(rf::prereq::node_method_label)?"; then
+        # Default to yes -- see the PowerShell equivalent for rationale:
+        # refusing means the installer aborts and the user has to install
+        # Node manually and re-run, which is worse than just letting us
+        # install it. Saying no is still one keystroke (`n`).
+        if ! rf::confirm "Install Node.js LTS now via $(rf::prereq::node_method_label)?" y; then
             rf::err "Node.js is required to proceed. Install it from https://nodejs.org and re-run agents.sh."
             return 1
         fi